Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): Added optional argument to specify description for pipeline upload #4577

Merged

Conversation

shaikmanu797
Copy link
Contributor

Added optional argument -d, --pipeline-description to provide value for the pipeline description to be uploaded

$ kfp pipeline upload --help
Usage: kfp pipeline upload [OPTIONS] PACKAGE_FILE

  Upload a KFP pipeline

Options:
  -p, --pipeline-name TEXT        Name of the pipeline.
  -d, --pipeline-description TEXT
                                  Description for the pipeline.
  --help                          Show this message and exit.

Checklist:

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @shaikmanu797. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 2, 2020

/ok-to-test

@shaikmanu797
Copy link
Contributor Author

/retest

@shaikmanu797
Copy link
Contributor Author

@numerology / @Ark-kun The check failure seems to be inherited from the failure on the master branch.

Let me know if you are fixing this failure.

@NikeNano
Copy link
Member

NikeNano commented Oct 3, 2020

/test kubeflow-pipeline-sample-test

@click.argument("package-file")
@click.pass_context
def upload(ctx, pipeline_name, package_file):
def upload(ctx, package_file, pipeline_name, pipeline_description=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason for changing the order of pipeline_name and package_file, suggest we keep the old to not break the previous behaviour.

nit: suggest to keep the name to description to be aligned with the arguments for client.upload_pipeline, docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NikeNano Made the changes based on your suggestions. The order of arguments is changed to original and renamed the pipeline_description to just description.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realised it would not have brooken anything since this uses click and then the order should not matter.

@shaikmanu797
Copy link
Contributor Author

The test failure seems to be irrelevant to this PR and is due to a missing dependency version in the environment required by this repository.

sample-test-hdm6t-777353900: ERROR: Could not find a version that satisfies the requirement tensorflow==1.8.0 (from versions: 1.13.0rc1, 1.13.0rc2, 1.13.1, 1.13.2, 1.14.0rc0, 1.14.0rc1, 1.14.0, 1.15.0rc0, 1.15.0rc1, 1.15.0rc2, 1.15.0rc3, 1.15.0, 1.15.2, 1.15.3, 1.15.4, 2.0.0a0, 2.0.0b0, 2.0.0b1, 2.0.0rc0, 2.0.0rc1, 2.0.0rc2, 2.0.0, 2.0.1, 2.0.2, 2.0.3, 2.1.0rc0, 2.1.0rc1, 2.1.0rc2, 2.1.0, 2.1.1, 2.1.2, 2.2.0rc0, 2.2.0rc1, 2.2.0rc2, 2.2.0rc3, 2.2.0rc4, 2.2.0, 2.2.1, 2.3.0rc0, 2.3.0rc1, 2.3.0rc2, 2.3.0, 2.3.1)
sample-test-hdm6t-777353900: ERROR: No matching distribution found for tensorflow==1.8.0

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 5, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 7, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit dd1e3d8 into kubeflow:master Oct 7, 2020
@shaikmanu797 shaikmanu797 deleted the allow_pipeline_description branch October 7, 2020 12:35
@Bobgy Bobgy added cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` labels Oct 10, 2020
Bobgy pushed a commit that referenced this pull request Oct 10, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` cla: yes lgtm ok-to-test size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants