-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): Added optional argument to specify description for pipeline upload #4577
feat(sdk): Added optional argument to specify description for pipeline upload #4577
Conversation
Hi @shaikmanu797. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
@numerology / @Ark-kun The check failure seems to be inherited from the failure on the master branch. Let me know if you are fixing this failure. |
/test kubeflow-pipeline-sample-test |
sdk/python/kfp/cli/pipeline.py
Outdated
@click.argument("package-file") | ||
@click.pass_context | ||
def upload(ctx, pipeline_name, package_file): | ||
def upload(ctx, package_file, pipeline_name, pipeline_description=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason for changing the order of pipeline_name
and package_file
, suggest we keep the old to not break the previous behaviour.
nit: suggest to keep the name to description
to be aligned with the arguments for client.upload_pipeline
, docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NikeNano Made the changes based on your suggestions. The order of arguments is changed to original and renamed the pipeline_description
to just description
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realised it would not have brooken anything since this uses click and then the order should not matter.
83620ee
to
a2040b7
Compare
The test failure seems to be irrelevant to this PR and is due to a missing dependency version in the environment required by this repository.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Added optional argument
-d, --pipeline-description
to provide value for the pipeline description to be uploaded$ kfp pipeline upload --help Usage: kfp pipeline upload [OPTIONS] PACKAGE_FILE Upload a KFP pipeline Options: -p, --pipeline-name TEXT Name of the pipeline. -d, --pipeline-description TEXT Description for the pipeline. --help Show this message and exit.
Checklist:
Do you want this pull request (PR) cherry-picked into the current release branch?
Learn more about cherry-picking updates into the release branch.