Fix sample test - Add gcp permission #454
Conversation
|
Do not forget to update the notebook samples. |
|
/test presubmit-sample-test-v2 |
|
/test presubmit-sample-test |
IronPan
changed the title
|
/assign @qimingj @gaoning777 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Ensure the storage initializer container and queue_proxy container have CPU/Memory Limust/Request fix storage initializer config name revert back default storageInitializer config rename commonConfig to deploymentConfig only config CPU/Memory Limit/Request for storage initializer from the configmap no longer exposes queue_proxy CPU/Memory configuration in the configmap but still set QueueSideCarResourcePercentageAnnotation in kfservice remove DeploymentConfig update gitignore only set DefaultQueueSideCarResourcePercentage if it is not set lower the memory request for storage initializer increase the cpu and memory limit in e2e tests fix rebase ignore .DS_Store in every folder and subfolder debug e2e address review comments * change the percentage to 0.2 to pass knative admission webhook * fix unit tests * remove extra err check * move common annotations for predictor, transformer and explainer to a common function * kill some boilerplate in unit test * address review comments
This change is