Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(components): De-hardcoded local output paths. #4495

Merged
merged 6 commits into from
Jun 8, 2021
Merged

refactor(components): De-hardcoded local output paths. #4495

merged 6 commits into from
Jun 8, 2021

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Sep 14, 2020

Re-doing #580

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ark-kun
You can assign the PR to them by writing /assign @ark-kun in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeflow-bot
Copy link

This change is Reviewable

@google-cla google-cla bot added the cla: yes label Sep 14, 2020
@stale
Copy link

stale bot commented Dec 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Dec 18, 2020
@chensun chensun force-pushed the master branch 2 times, most recently from 7542f0e to 44d22a6 Compare February 12, 2021 09:23
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this Jun 2, 2021
@Ark-kun Ark-kun reopened this Jun 4, 2021
@stale stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 4, 2021
@Bobgy
Copy link
Contributor

Bobgy commented Jun 7, 2021

@Ark-kun can you resolve the conflicts? I think those files are deleted

@Ark-kun Ark-kun force-pushed the Components---De-hardcoded-local-output-paths branch from dc8937c to 81fa904 Compare June 7, 2021 20:49
@Ark-kun Ark-kun force-pushed the Components---De-hardcoded-local-output-paths branch from 81fa904 to 210ea7c Compare June 7, 2021 21:25
@Ark-kun Ark-kun marked this pull request as ready for review June 7, 2021 21:28
@zijianjoy
Copy link
Collaborator

/lgtm
/approve

Thank you Alexey for the changes!

@Bobgy
Copy link
Contributor

Bobgy commented Jun 8, 2021

/approve
Thanks!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit cd4aa7d into kubeflow:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun Awaiting requested review from chensun

@Bobgy Bobgy Awaiting requested review from Bobgy

@numerology numerology Awaiting requested review from numerology

@animeshsingh animeshsingh Awaiting requested review from animeshsingh

Assignees

@chensun chensun

@Bobgy Bobgy

@numerology numerology

@zijianjoy zijianjoy

Labels
approved area/components cla: yes lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Ark-kun @k8s-ci-robot @kubeflow-bot @Bobgy @zijianjoy @google-oss-robot @chensun @numerology