Show pipeline details embedded in runs #447
Conversation
| return ( | ||
| <Link className={commonCss.link} onClick={(e) => e.stopPropagation()} | ||
| to={url}> | ||
| {pipelineInfo.showLink ? 'View pipeline' : pipelineInfo.displayName} |
There was a problem hiding this comment.
nit: I think maybe [View pipeline] would be better? something to help distinguish it visually from a normal pipeline name?
Or maybe we don't actually care about that
There was a problem hiding this comment.
I think we should distinguish them too. I'll add @ajayalfred here for follow up, but for now I think we can merge this whenever it's ready until we hear back from him.
There was a problem hiding this comment.
I'll check with Jordan and comment back here.
|
/test build-image |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* kind/feature should also use improvement/enhancement as previous value * Cleanup some of the area labels Related to kubeflow#440
Runs created in notebooks (or created the same way using API/CLI) do not contain a pipeline ID reference. Instead, they contain the entire pipeline spec embedded inside the run object. This PR handles extracting the pipeline details from there and showing them in the
PipelineDetailsview.Some other small fixes:
QUERY_PARAMSto Router component to make all routing definitions in one place.PipelineDetailspage.RunListto be public. I think this makes more sense, since they really are part of the public API, and can be called as such.Part of #75.
This change is