Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update owners file #4316

Merged
merged 3 commits into from
Aug 6, 2020
Merged

update owners file #4316

merged 3 commits into from
Aug 6, 2020

Conversation

animeshsingh
Copy link
Contributor

multiple sample being requested to review and approve. And have been reviewing them for more than a year now.

@animeshsingh
update owners file
d697d20 
multiple sample being requested to review and approve. And have been reviewing them for more than a year now.
@google-cla google-cla bot added the cla: yes label Aug 3, 2020
@kubeflow-bot
Copy link

This change is Reviewable

@Bobgy
Copy link
Contributor

Bobgy commented Aug 4, 2020

Can you point to which samples?
Does it make sense moving those samples to a lower level folder and grant OWNERS there?

@animeshsingh
Copy link
Contributor Author

@Bobgy there is already a PR pending on KFServing and Seldon samples. Key is we can keep on going granular, or you need to be gatekeeper for every sample coming in?

@neuromage
Copy link
Contributor

@animeshsingh I think we can have an OWNERS file for the contrib directory if needed instead. Will that help?

@animeshsingh
Copy link
Contributor Author

@neuromage yes that will be great!

@neuromage
Copy link
Contributor

Thanks @animeshsingh. I think the only difference is that samples under core are tested as part of our Prow tests kubeflow-pipeline-sample-test. Do you want to go ahead an update this PR with an OWNERS file in contrib instead? Thanks!

@animeshsingh
Copy link
Contributor Author

ok done @neuromage

@numerology
Copy link

/lgtm
/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor

Bobgy commented Aug 6, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit d135693 into kubeflow:master Aug 6, 2020
chensun pushed a commit to chensun/pipelines that referenced this pull request Aug 7, 2020
@animeshsingh @chensun
update owners file (kubeflow#4316)
f7acd98 
* update owners file

multiple sample being requested to review and approve. And have been reviewing them for more than a year now.

* Revert changes

* create OWNERS file in contrib
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@animeshsingh @Jeffwan
update owners file (kubeflow#4316)
5d4f573 
* update owners file

multiple sample being requested to review and approve. And have been reviewing them for more than a year now.

* Revert changes

* create OWNERS file in contrib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@rmgogogo rmgogogo Awaiting requested review from rmgogogo

Assignees

@numerology numerology

Labels
approved cla: yes lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@animeshsingh @kubeflow-bot @Bobgy @neuromage @numerology @k8s-ci-robot