Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployment): Add env/platform-agnostic-pns standalone deployment option #4278

Merged
merged 1 commit into from
Aug 4, 2020
Merged

feat(deployment): Add env/platform-agnostic-pns standalone deployment option #4278

merged 1 commit into from
Aug 4, 2020

Conversation

Gsantomaggio
Copy link
Member

Description of your changes:
Add containerRuntimeExecutor explicit type on workflow-controller-configmap.yaml configuration.
docker is the default.
platform-agnostic-pns type configuration needed by Kind, K3s and Minikube.
Part of #4256
Related to: kubeflow/website#2056

Checklist:

example new PNS feature:

kubectl kustomize  manifests/kustomize/env/platform-agnostic-pns | grep containerRuntimeExecutor -A 5
  containerRuntimeExecutor: pns
  dbHost: mysql
  dbPort: "3306"
  mlmdDb: metadb
  pipelineDb: mlpipeline
kind: ConfigMap
--
    containerRuntimeExecutor: pns,
    artifactRepository:
    {
        s3: {
            bucket: mlpipeline,
            keyPrefix: artifacts,

example with docker feature:

 kubectl kustomize  manifests/kustomize/env/platform-agnostic | grep containerRuntimeExecutor -A 5
  containerRuntimeExecutor: docker
  dbHost: mysql
  dbPort: "3306"
  mlmdDb: metadb
  pipelineDb: mlpipeline
kind: ConfigMap
--
    containerRuntimeExecutor: docker,
    artifactRepository:
    {
        s3: {
            bucket: mlpipeline,
            keyPrefix: artifacts,

@google-cla google-cla bot added the cla: yes label Jul 27, 2020
@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @Gsantomaggio. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
other than the only one comment

Thank you for your contribution!

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought of one more comment

manifests/kustomize/base/params.env Show resolved Hide resolved
Add containerRuntimeExecutor explicit type on the configMap
configuration. Set `docker` as default.
Add platform-agnostic type configuration needed by Kind, K3s and
Minikube.
Part of #4256
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 2, 2020
@Gsantomaggio
Copy link
Member Author

@Bobgy @alfsuse it should be ready now!

@Bobgy
Copy link
Contributor

Bobgy commented Aug 3, 2020

Thank you! I think this is great!
/ok-to-test
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy Bobgy added the cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch label Aug 3, 2020
@Bobgy Bobgy changed the title feat(deployment): Add platform-agnostic-pns type feat(deployment): Add platform-agnostic-pns standalone deployment option Aug 3, 2020
@Bobgy Bobgy changed the title feat(deployment): Add platform-agnostic-pns standalone deployment option feat(deployment): Add env/platform-agnostic-pns standalone deployment option Aug 3, 2020
@Gsantomaggio
Copy link
Member Author

@Bobgy some test failed, but I am not sure is related to my changes. I trying to understand btw

@Bobgy
Copy link
Contributor

Bobgy commented Aug 3, 2020

/retest

I don't think they are related.

@Bobgy
Copy link
Contributor

Bobgy commented Aug 4, 2020

/retest

@rmgogogo
Copy link
Contributor

rmgogogo commented Aug 4, 2020

/lgtm

assume we won't bring it to MKP and I personally prefer no.

@k8s-ci-robot k8s-ci-robot merged commit dac5a94 into kubeflow:master Aug 4, 2020
chensun pushed a commit to chensun/pipelines that referenced this pull request Aug 7, 2020
… option (kubeflow#4278)

Add containerRuntimeExecutor explicit type on the configMap
configuration. Set `docker` as default.
Add platform-agnostic type configuration needed by Kind, K3s and
Minikube.
Part of kubeflow#4256
jingzhang36 pushed a commit to jingzhang36/pipelines that referenced this pull request Aug 12, 2020
… option (kubeflow#4278)

Add containerRuntimeExecutor explicit type on the configMap
configuration. Set `docker` as default.
Add platform-agnostic type configuration needed by Kind, K3s and
Minikube.
Part of kubeflow#4256
Bobgy pushed a commit that referenced this pull request Aug 12, 2020
… option (#4278)

Add containerRuntimeExecutor explicit type on the configMap
configuration. Set `docker` as default.
Add platform-agnostic type configuration needed by Kind, K3s and
Minikube.
Part of #4256
@jingzhang36 jingzhang36 added the cherrypicked cherry picked to release branch `release-x.y` label Aug 12, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
… option (kubeflow#4278)

Add containerRuntimeExecutor explicit type on the configMap
configuration. Set `docker` as default.
Add platform-agnostic type configuration needed by Kind, K3s and
Minikube.
Part of kubeflow#4256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` cla: yes lgtm ok-to-test size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants