-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deployment): Add env/platform-agnostic-pns standalone deployment option #4278
Conversation
Hi @Gsantomaggio. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
other than the only one comment
Thank you for your contribution!
manifests/kustomize/base/argo/workflow-controller-configmap.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought of one more comment
Add containerRuntimeExecutor explicit type on the configMap configuration. Set `docker` as default. Add platform-agnostic type configuration needed by Kind, K3s and Minikube. Part of #4256
Thank you! I think this is great! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Bobgy some test failed, but I am not sure is related to my changes. I trying to understand btw |
/retest I don't think they are related. |
/retest |
/lgtm assume we won't bring it to MKP and I personally prefer no. |
… option (kubeflow#4278) Add containerRuntimeExecutor explicit type on the configMap configuration. Set `docker` as default. Add platform-agnostic type configuration needed by Kind, K3s and Minikube. Part of kubeflow#4256
… option (kubeflow#4278) Add containerRuntimeExecutor explicit type on the configMap configuration. Set `docker` as default. Add platform-agnostic type configuration needed by Kind, K3s and Minikube. Part of kubeflow#4256
… option (kubeflow#4278) Add containerRuntimeExecutor explicit type on the configMap configuration. Set `docker` as default. Add platform-agnostic type configuration needed by Kind, K3s and Minikube. Part of kubeflow#4256
Description of your changes:
Add
containerRuntimeExecutor
explicit type onworkflow-controller-configmap.yaml
configuration.docker
is the default.platform-agnostic-pns type configuration needed by Kind, K3s and Minikube.
Part of #4256
Related to: kubeflow/website#2056
Checklist:
The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.
PR titles examples:
feat(deployment): configurable containerRuntimeExecutor
fixes (part of) Document how to run KFP on local Kubernetes cluster like Kind, k3s, minikube #4256example new PNS feature:
example with docker feature: