fix(cache): adds certificate approver permission to kubeflow-pipelines-cache-deployer-role. Fixes #4138

[eedorenko]

Fixes #4138

Adds certificate approver permission to kubeflow-pipelines-cache-deployer-role.
Without this permission cache-deployer-deployment crashes with the following error:
Error from server (Forbidden): certificatesigningrequests.certificates.k8s.io "cache-server.kubeflow" is forbidden: user not permitted to approve requests with signerName "kubernetes.io/legacy-unknown

[kubeflow-bot]

This change is 

[k8s-ci-robot]

Hi @eedorenko. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Ark-kun]

Hello.

What kind of Kubernetes cluster are you using?

It looks like the permissions in this PR should have already been granted: https://github.com/kubeflow/pipelines/blob/master/manifests/kustomize/base/cache-deployer/cluster-scoped/cache-deployer-clusterrole.yaml

Do you have that role installed?

[Bobgy]

@Ark-kun note that one permission is for signer, that's a new resource in later Kubernetes versions.
The first report of this issue was in #4138.

So this should fix the permission issue for k8s 1.18

[Bobgy]

/ok-to-test

[eedorenko]

AKS 1.18.4. And yes, it looks like it fixes #4138

[Ark-kun]

Should this be added to Role or ClusterRole?

[Bobgy]

@eedorenko can you adapt your PR to remove duplicates with https://github.com/kubeflow/pipelines/blob/master/manifests/kustomize/base/cache-deployer/cluster-scoped/cache-deployer-clusterrole.yaml?

We are deploying both a clusterrole and a role for cache-deployer, note https://kubernetes.io/docs/reference/access-authn-authz/rbac/#role-and-clusterrole, only permissions for cluster scoped resources are declared in the clusterrole.

[eedorenko]

@Bobgy Done.

[Bobgy]

Why was list and watch needed?
They were not mentioned in your PR's description error message.

[eedorenko]

It comes from https://kubernetes.io/docs/reference/access-authn-authz/certificate-signing-requests/#authorization

[Bobgy]

Can you confirm if this works without them?
as far as I know, current permissions are enough, we are not listing or watching them

[eedorenko]

I confirm. Updated the PR

[Bobgy]

Thanks for the contribution! @eedorenko
/lgtm
/approve

@haibingzhao, this should have fixed the issue you reported.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• manifests/kustomize/OWNERS [Bobgy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Ark-kun]

@eedorenko Please check #4383