Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Components - Temporary removed Kubernetes options from ComponentSpec #4230

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jul 17, 2020

This reduces the schema size and we can replace it with more generic attribute - launcherOptions
The kubernetesOptions was an ignored field since support for it was not implemented in the KFP component bridge yet.

Splitting the "Replaced Kubernetes options with generic launcher options" PR into two:

  • This PR removes the kubernetesOptions field.
  • A future PR will add the launcherOptions map to replace it.

…options

This reduces the schema size and makes the task launcher options more flexible.
@kubeflow-bot
Copy link

This change is Reviewable

@google-cla google-cla bot added the cla: yes label Jul 17, 2020
@Ark-kun Ark-kun added cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch and removed cla: yes labels Jul 17, 2020
@google-cla google-cla bot added the cla: yes label Jul 17, 2020
@Ark-kun Ark-kun force-pushed the SDK---Components---Removed-KubernetesOptions branch from 0940817 to 44e7b73 Compare July 17, 2020 02:13
@Bobgy
Copy link
Contributor

Bobgy commented Jul 17, 2020

Thanks @Ark-kun!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 39975e3 into kubeflow:master Jul 17, 2020
@Bobgy Bobgy added the cherrypicked cherry picked to release branch `release-x.y` label Jul 20, 2020
Bobgy pushed a commit that referenced this pull request Jul 20, 2020
…tSpec (#4230)

* SDK - Components - Replaced Kubernetes options with generic launcher options

This reduces the schema size and makes the task launcher options more flexible.

* Removed the launcherOptions for now
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
…tSpec (kubeflow#4230)

* SDK - Components - Replaced Kubernetes options with generic launcher options

This reduces the schema size and makes the task launcher options more flexible.

* Removed the launcherOptions for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/sdk/components cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` cla: yes lgtm size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants