Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): [AWS SageMaker] Minimize inputs for mnist classification pipeline #4192

Merged
merged 8 commits into from
Jul 17, 2020
Merged

feat(components): [AWS SageMaker] Minimize inputs for mnist classification pipeline #4192

merged 8 commits into from
Jul 17, 2020

Conversation

surajkota
Copy link
Contributor

@surajkota surajkota commented Jul 9, 2020 •
edited
Loading

Description of your changes:

  • Minimize inputs for mnist classification pipeline - remove unused inputs and inputs with default values for better user experience
  • Bug fixes
    • To processing component, current pipeline on master fails at batch transform
    • Script used for prediction had missing imports and reference to dataset section which is not present anymore
  • Updates to documentation and fixes
  • Made s3 bucket as runtime input rather than compile time - easy for customer and to add integration tests

Testing
Manual

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from Jeffwan and mameshini July 9, 2020 21:26
buildgreatthings
buildgreatthings reviewed Jul 9, 2020
View reviewed changes
Copy link

@buildgreatthings buildgreatthings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional fields we can cut down

samples/contrib/aws-samples/mnist-kmeans-sagemaker/mnist-classification-pipeline.py Outdated Show resolved Hide resolved
samples/contrib/aws-samples/mnist-kmeans-sagemaker/mnist-classification-pipeline.py Outdated Show resolved Hide resolved
samples/contrib/aws-samples/mnist-kmeans-sagemaker/mnist-classification-pipeline.py Outdated Show resolved Hide resolved
samples/contrib/aws-samples/mnist-kmeans-sagemaker/mnist-classification-pipeline.py Outdated Show resolved Hide resolved
samples/contrib/aws-samples/mnist-kmeans-sagemaker/mnist-classification-pipeline.py Outdated Show resolved Hide resolved
samples/contrib/aws-samples/mnist-kmeans-sagemaker/mnist-classification-pipeline.py Outdated Show resolved Hide resolved
samples/contrib/aws-samples/mnist-kmeans-sagemaker/mnist-classification-pipeline.py Outdated Show resolved Hide resolved
@RedbackThomson
Copy link
Contributor

/approve

@RedbackThomson
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6860681 into kubeflow:master Jul 17, 2020
@RedbackThomson RedbackThomson mentioned this pull request Jul 29, 2020
Merged
2 tasks
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@surajkota @Jeffwan
feat(components): [AWS SageMaker] Minimize inputs for mnist classific…
1b0003b 
…ation pipeline (kubeflow#4192)

* minimize parameters and bug fixes

* endpoint_name variable fix

* only add necessary inputs

* remove run_time

* trim down v2

* Update example with S3 bucket as runtime input

* nit fix

* fix variable names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buildgreatthings buildgreatthings buildgreatthings left review comments

@RedbackThomson RedbackThomson RedbackThomson approved these changes

@akartsky akartsky akartsky approved these changes

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

@mameshini mameshini Awaiting requested review from mameshini

Assignees

@RedbackThomson RedbackThomson

Labels
approved cla: yes lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@surajkota @kubeflow-bot @RedbackThomson @k8s-ci-robot @buildgreatthings @akartsky @googlebot