Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): fix parsing large workflow graph. Fixes #4179 #4180

Merged
merged 37 commits into from
Oct 16, 2020
Merged

fix(frontend): fix parsing large workflow graph. Fixes #4179 #4180

Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
b693997
frontend: add large pipeline example to mocked data
radcheb Jul 8, 2020
01f4a61
add util function decodeCompressedNodes
radcheb Jul 8, 2020
b544eb8
decode compressedNodes in workflow if node is empty and compressedNod…
radcheb Jul 8, 2020
7736eef
fix decodeCompressedNodes
radcheb Jul 8, 2020
a21a73f
prettify code
radcheb Jul 8, 2020
71dd186
Frontend:test Utils decodeCompressedNodes
radcheb Aug 9, 2020
a0d91aa
test RunDetails page render compressed grah
radcheb Aug 9, 2020
ebdec29
add util function decodeCompressedNodes
radcheb Jul 8, 2020
0d0f6d4
Frontend:test Utils decodeCompressedNodes
radcheb Aug 9, 2020
a0fe147
test RunDetails page render compressed grah
radcheb Aug 9, 2020
ea76e79
reformat code
radcheb Aug 9, 2020
bec5db4
update jest snapshot to add compressed node case
radcheb Aug 9, 2020
c436dc7
fix tests
radcheb Aug 13, 2020
9981e3e
reformat code
radcheb Aug 15, 2020
5aa139a
update RunDetails snapshot
radcheb Aug 15, 2020
76614a3
remove dupplicate test code
radcheb Aug 15, 2020
e68d567
RunDetails: remove compressedNodes after decoding it
radcheb Aug 16, 2020
38ca3f6
reformat decodeCompressedNodes + add failure case test
radcheb Aug 16, 2020
4018c1f
decodeCompressedNodes returns undefined on error
radcheb Aug 16, 2020
8c13353
RunDetails decodeCompressedNodes test: snapshot same as single node g…
radcheb Aug 16, 2020
d59a460
do not wait for decodeCompressedNodes + debug print workflow
radcheb Aug 16, 2020
14e20c9
Merge branch 'master' into frontend-fix-parse-large-workflow
radcheb Oct 4, 2020
ac4b463
fix Run load + refresh snapshot
radcheb Oct 4, 2020
66b2456
format code
radcheb Oct 4, 2020
4587827
Merge branch 'master' into frontend-fix-parse-large-workflow
radcheb Oct 7, 2020
e6a0435
Fix one-node compressed workflow graph + update snapshot
radcheb Oct 7, 2020
5ea75b6
reformat code
radcheb Oct 7, 2020
ff37a9e
rename large pipeline name
radcheb Oct 8, 2020
9038244
fix decompressNodes to work in browser
radcheb Oct 8, 2020
c1b698c
fix test
radcheb Oct 8, 2020
8958105
fix tests
radcheb Oct 8, 2020
1cf8643
remove some of the console.log
radcheb Oct 8, 2020
83b2c1a
clean code
radcheb Oct 9, 2020
e93a060
address comments
radcheb Oct 12, 2020
8491c5c
address comments: wait for zlib instead of mocking decodeCompressedNodes
radcheb Oct 13, 2020
5b46a4d
address comments: decodeCompressedNodes reject in case of error + cat…
radcheb Oct 13, 2020
0415d6b
address comments
radcheb Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update RunDetails snapshot
  • Loading branch information
@radcheb
radcheb committed Aug 15, 2020
commit 5aa139a7524d4d1ef4f8d9a227740ebf69aab50c
6 changes: 6 additions & 0 deletions frontend/src/pages/__snapshots__/RunDetails.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1144,6 +1144,12 @@ exports[`RunDetails shows a one-node compressed workflow graph 1`] = `
/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sth seems wrong, the snapshot is empty.
If you compare it to snapshot of the one node test, it has some content

`;

exports[`RunDetails shows a one-node compressed workflow graph 2`] = `
<div
className="page"
/>
`;

exports[`RunDetails shows a one-node graph 1`] = `
<div
className="page"
Expand Down