Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): SDK - Enable placeholders in task display names. Fixes #4163 #4164

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jul 7, 2020

Fixes #4163

@kubeflow-bot
Copy link

This change is Reviewable

@Ark-kun Ark-kun changed the title feat(sdk): SDK - Enable placeholders in task display names Fixes #4163 feat(sdk): SDK - Enable placeholders in task display names. Fixes #4163 Jul 7, 2020
@k8s-ci-robot k8s-ci-robot requested a review from IronPan July 7, 2020 20:55
@numerology
Copy link

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 10, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK - Support placeholders in task display names
7 participants