Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK/Tests/Components - Corrected test argument types #41

Merged
merged 2 commits into from
Nov 5, 2018
Merged

SDK/Tests/Components - Corrected test argument types #41

merged 2 commits into from
Nov 5, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 5, 2018 •
edited by jlewi
Loading

This change is Reviewable

@qimingj
Copy link
Contributor

qimingj commented Nov 5, 2018

Why does float works but not integer?

@Ark-kun Ark-kun requested review from gaoning777 and removed request for vicaire and rileyjbauer November 5, 2018 19:36
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 5, 2018

Why does float works but not integer?

str(int(8)) != str(float(8))

str(8) != str(8.0)

@qimingj
Copy link
Contributor

qimingj commented Nov 5, 2018

/approval /LGTM

@qimingj
Copy link
Contributor

qimingj commented Nov 5, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qimingj
Copy link
Contributor

qimingj commented Nov 5, 2018

/lgtm

@qimingj qimingj merged commit e77a91f into master Nov 5, 2018
@Ark-kun Ark-kun deleted the avolkov/Correct-argument-types branch November 9, 2018 23:35
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@texasmichelle @jlewi
Fix broken link, add newline to EOF (kubeflow#41)
9d14393 
* Fix broken link, add newline to EOF

* Fix broken checkout.sh link
HumairAK added a commit to HumairAK/data-science-pipelines that referenced this pull request May 28, 2024
@HumairAK
Merge pull request kubeflow#41 from HumairAK/fix_cc
2bc028c 
UPSTREAM: <carry>: move commit checker to separate wf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qimingj qimingj qimingj approved these changes

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@qimingj qimingj

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @qimingj @k8s-ci-robot @google-prow-robot