-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): CLI - Allow upload_version by the pipeline's name. Fixes #3901 #4087
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
8eae9c1
Update _client.py
33d3ac4
Allow for passing name instead of only pipeline_id
91726cf
fixed old rebase issue
13df138
protobuf fix
cb03f8b
raise error and remove f-string
43603ec
moved file
3662432
updated python proto packages versions
b5815c3
Update sdk/python/kfp/_client.py
1fc5678
restructured and added to build
8fe2176
changes structure of import
c0708c0
Merge branch 'cli_update' of github.com:NikeNano/pipelines into cli_u…
ba864d8
Updated the files
dd3c0b5
further updates of client and filter.proto
03c6fa3
alternative
9685f86
clean up
acfd9ee
clean up
ee829f4
remove helperfiles
30402b5
futher clean up
5492df7
clean up or eaither name or id
99d32e6
update doc strings
d543400
remove page_size
778f3ed
Update sdk/python/kfp/_client.py
0ab53b0
Update sdk/python/kfp/cli/pipeline.py
330eacb
updated to classical string formattin
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my education, is the predicates other than 'EQUALS' being used now in the client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, they are not I kept them on order to have a reference for the alternative since we don't have a proper helper file. Maybe we should remove it. Initially I only. set it to 1, but @Bobgy suggested that we added a mapping in order for readers of the code to understand what it meant.