Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Bug fix: applying filter in listing versions #4052

Merged
merged 9 commits into from
Jun 23, 2020

Conversation

jingzhang36
Copy link
Contributor

@jingzhang36 jingzhang36 commented Jun 23, 2020

Description of your changes:
Fixes #3867

Checklist:

  • Do you want this pull request (PR) cherry-picked into the current release branch?

    If yes, use one of the following options:

    • (Recommended.) Ask the PR approver to add the cherrypick-approved label to this PR. The release manager adds this PR to the release branch in a batch update.
    • After this PR is merged, create a cherry-pick PR to add these changes to the release branch. (For more information about creating a cherry-pick PR, see the Kubeflow Pipelines release guide.)

@kubeflow-bot
Copy link

This change is Reviewable

@Bobgy
Copy link
Contributor

Bobgy commented Jun 23, 2020

Thanks for the fix! @jingzhang36
/lgtm

@Bobgy Bobgy added the cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch label Jun 23, 2020
@jingzhang36
Copy link
Contributor Author

/approve

1 similar comment
@Bobgy
Copy link
Contributor

Bobgy commented Jun 23, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, jingzhang36

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jingzhang36
Copy link
Contributor Author

/test kubeflow-pipeline-frontend-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 23, 2020

/retest

2 similar comments
@jingzhang36
Copy link
Contributor Author

/retest

@jingzhang36
Copy link
Contributor Author

/retest

@jingzhang36
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test
/test kubeflow-pipeline-sample-test

@k8s-ci-robot k8s-ci-robot merged commit 6fdf03a into kubeflow:master Jun 23, 2020
@Bobgy Bobgy added the cherrypicked cherry picked to release branch `release-x.y` label Jul 2, 2020
Bobgy pushed a commit that referenced this pull request Jul 2, 2020
* enable pagination when expanding experiment in both the home page and the archive page

* Revert "enable pagination when expanding experiment in both the home page and the archive page"

This reverts commit 5b67273.

* add filter for listing versions

* add another filter in test

* comment revision
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* enable pagination when expanding experiment in both the home page and the archive page

* Revert "enable pagination when expanding experiment in both the home page and the archive page"

This reverts commit 5b67273.

* add filter for listing versions

* add another filter in test

* comment revision
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/backend cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET Pipeline Version API endpoint doesn't filter based on filter predicates
5 participants