Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CherryPick: Only pending or running workflows are considered not-final (#3940) #3957

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

jingzhang36
Copy link
Contributor

  • only pending or running workflows are considered not-final

  • rephrase comment

…3940)

* only pending or running workflows are considered not-final

* rephrase comment
@kubeflow-bot
Copy link

This change is Reviewable

@jingzhang36
Copy link
Contributor Author

/assign @Bobgy
/assign @rmgogogo

@Bobgy
Copy link
Contributor

Bobgy commented Jun 11, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b021b7c into kubeflow:release-1.0 Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants