Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python Client] Clean up generated python client template to facilitate version bump #3937

Merged
merged 3 commits into from
Jun 10, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jun 9, 2020

Fixes #3927 (comment)

/assign @Ark-kun
/cc @rmgogogo @jingzhang36

Changes:

  • Removed version from generated client file header, so that version bump diff will be minimal (there are still a few places left, but I think that's acceptable now).

Demo: after the change, a version bump on the generated python client from 1.0.0-dev.1 to 1.0.0-dev.2 looks like aa1f0e8 as demonstrated.

Implementation:

  • Added a openapi-generator override template to customize the behavior

@kubeflow-bot
Copy link

This change is Reviewable

Comment on lines +1 to +14
"""
{{#appName}}
{{{appName}}}
{{/appName}}

{{#appDescription}}
{{{appDescription}}}
{{/appDescription}}

{{#infoEmail}}
Contact: {{{infoEmail}}}
{{/infoEmail}}
Generated by: https://openapi-generator.tech
"""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 10, 2020

Thanks for cleaning and stabilizing the client package!
/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 10, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c6ac5e0 into kubeflow:master Jun 10, 2020
@Bobgy Bobgy deleted the openapi_generator_template branch June 10, 2020 01:24
Bobgy added a commit to Bobgy/pipelines that referenced this pull request Jun 10, 2020
Bobgy added a commit to Bobgy/pipelines that referenced this pull request Jun 10, 2020
RedbackThomson pushed a commit to RedbackThomson/pipelines that referenced this pull request Jun 17, 2020
…te version bump (kubeflow#3937)

* Remove version from generated python client header comment

* Regenerate client

* Bump to 1.0.0-dev.2 to showcase version bump diff
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
…te version bump (kubeflow#3937)

* Remove version from generated python client header comment

* Regenerate client

* Bump to 1.0.0-dev.2 to showcase version bump diff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants