-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python Client] Clean up generated python client template to facilitate version bump #3937
[Python Client] Clean up generated python client template to facilitate version bump #3937
Conversation
""" | ||
{{#appName}} | ||
{{{appName}}} | ||
{{/appName}} | ||
|
||
{{#appDescription}} | ||
{{{appDescription}}} | ||
{{/appDescription}} | ||
|
||
{{#infoEmail}} | ||
Contact: {{{infoEmail}}} | ||
{{/infoEmail}} | ||
Generated by: https://openapi-generator.tech | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the template override. Original template at https://github.com/OpenAPITools/openapi-generator/blob/v4.3.1/modules/openapi-generator/src/main/resources/python/partial_header.mustache
Thanks for cleaning and stabilizing the client package! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…te version bump (kubeflow#3937) * Remove version from generated python client header comment * Regenerate client * Bump to 1.0.0-dev.2 to showcase version bump diff
…te version bump (kubeflow#3937) * Remove version from generated python client header comment * Regenerate client * Bump to 1.0.0-dev.2 to showcase version bump diff
Fixes #3927 (comment)
/assign @Ark-kun
/cc @rmgogogo @jingzhang36
Changes:
Demo: after the change, a version bump on the generated python client from 1.0.0-dev.1 to 1.0.0-dev.2 looks like aa1f0e8 as demonstrated.
Implementation: