Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Fix $(cat VERSION) not in bash script #3924

Merged
merged 2 commits into from
Jun 5, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jun 5, 2020

I made a mistake in #3921.
$(cat /workspace/VERSION) cannot be used in arguments, it has to be part of a bash script.

@Bobgy Bobgy added area/release kind/misc types beside feature and bug labels Jun 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ironpan
You can assign the PR to them by writing /assign @ironpan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeflow-bot
Copy link

This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 5, 2020

This can only get tested when merged.

@Bobgy Bobgy merged commit b0466cb into kubeflow:master Jun 5, 2020
@Bobgy Bobgy deleted the fix_tag_name_2 branch June 5, 2020 07:27
Bobgy added a commit to Bobgy/pipelines that referenced this pull request Jun 5, 2020
* [Release] Fix $(cat VERSION) not in bash script

* Add doublequote
Bobgy added a commit that referenced this pull request Jun 5, 2020
* [Release] Fix $(cat VERSION) not in bash script

* Add doublequote
RedbackThomson pushed a commit to RedbackThomson/pipelines that referenced this pull request Jun 17, 2020
* [Release] Fix $(cat VERSION) not in bash script

* Add doublequote
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* [Release] Fix $(cat VERSION) not in bash script

* Add doublequote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release kind/misc types beside feature and bug size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants