Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete kf_deploy.sh #391

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Delete kf_deploy.sh #391

merged 1 commit into from
Nov 28, 2018

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Nov 27, 2018

This is not needed any more since the entry is already integrated into kubeflow repo


This change is Reviewable

This is not needed any more since the entry is already integrated into kubeflow repo
@IronPan
Copy link
Member Author

IronPan commented Nov 27, 2018

/assign @yebrahim @jlewi

@yebrahim
Copy link
Contributor

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Nov 27, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a177e9d into master Nov 28, 2018
@IronPan IronPan deleted the IronPan-patch-9 branch December 10, 2018 22:26
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* Aggressively cleanup failed deployments.

* If a deployment is in error state; we want to clean it up pretty quickly
  and not wait several hours.

  * The problem is if deployments start failing because of quota issues
    these will stack up and we may not recover. But if we aggresively
    delete failed deployments this should help.

* Related to kubeflow#391

* Fix lint.
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants