Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up vendor directory #390

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Clean up vendor directory #390

merged 1 commit into from
Nov 27, 2018

Conversation

neuromage
Copy link
Contributor

@neuromage neuromage commented Nov 27, 2018

I ran dep ensure on a clean master to update the vendor directory, which resulted in the changes seen in this PR. Ideally dep ensure on master should not change vendor directory if all changes have been checked in.


This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from yebrahim and removed request for yebrahim November 27, 2018 18:22
@IronPan
Copy link
Member

IronPan commented Nov 27, 2018

/lgtm

@vicaire
Copy link
Contributor

vicaire commented Nov 27, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5714d65 into master Nov 27, 2018
@neuromage neuromage deleted the neuromage/filtering branch November 27, 2018 23:04
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* fix the cleanup-ci jsonnet

* print http reponse

* update scripts

* lint

* code complete

* handle zones

* lint

* remove global forwarding rules

* lint

* reorder clean ops

* add comment on order
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* add optional param

* update

* update naming

* pylint

* fix pylint
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* fix: dump "y" and "n" in enforced string mode

* import OrderedDit from collections instead of typing

* m: remove unused import in compiler.py

* m: formatting issues in yaml_utils (from linter)

* add copyrights to yaml_utils.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants