Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for minio hosted artifacts #389

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Add support for minio hosted artifacts #389

merged 2 commits into from
Nov 28, 2018

Conversation

vanpelt
Copy link
Contributor

@vanpelt vanpelt commented Nov 27, 2018

This adds support for artifact source urls that start with "minio://". I have a custom pipeline step that needs to write HTML to the local minio store instead of gcs. The artifacts API supports fetching urls from the local minio store, the url parser only supports "gs://".


This change is Reviewable

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@k8s-ci-robot
Copy link
Contributor

Hi @vanpelt. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

Hi @vanpelt. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vanpelt
Copy link
Contributor Author

vanpelt commented Nov 27, 2018

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @vanpelt!

@@ -504,6 +504,14 @@ describe('WorkflowParser', () => {
source: StorageService.GCS,
});
});

it('handles Minio bucket and multi-part key', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add more tests here to cover all the use cases just like we do for GCS paths above?

@yebrahim
Copy link
Contributor

/ok-to-test

@yebrahim
Copy link
Contributor

Looks good to me, thanks!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yebrahim
Copy link
Contributor

/test presubmit-e2e-test

@vanpelt
Copy link
Contributor Author

vanpelt commented Nov 27, 2018

@yebrahim can you get me into the slack channel for kubeflow? The invitation link on the community page is expired.

@yebrahim
Copy link
Contributor

Can you point to this expiring link? I thought the workspace was public, can you not sign up and join https://kubeflow.slack.com?

@jlewi @kunmingg do you guys have any more context?

@kunmingg
Copy link

@yebrahim
kubeflow/website#312
member in slack can also invite through email.

@yebrahim yebrahim merged commit f3789fb into kubeflow:master Nov 28, 2018
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants