Switching test to kubeflow deployment #351
Conversation
|
/test build-image |
1 similar comment
|
/test build-image |
|
/test presubmit-e2e-test |
1 similar comment
|
/test presubmit-e2e-test |
| @@ -69,8 +69,8 @@ echo "presubmit test starts" | |||
|
|
|||
| # activating the service account | |||
| gcloud auth activate-service-account --key-file="${GOOGLE_APPLICATION_CREDENTIALS}" | |||
| gcloud config set compute/zone us-central1-a | |||
There was a problem hiding this comment.
Why are we hard-coding the zone?
There was a problem hiding this comment.
currently we only requested quota for this zone.
test/presubmit-tests.sh
Outdated
|
|
||
| #Creating a new GKE cluster if needed |
|
/retest |
|
/test presubmit-e2e-test |
|
/test presubmit-sample-test-v2 |
1 similar comment
|
/test presubmit-sample-test-v2 |
|
Is the major change to configure the GCP credentials? |
|
/assign @Ark-kun @gaoning777 |
|
@gaoning777 to answer your question, this is switching the deployment, deprecating bootstrapper image. |
|
/lgtm |
|
/test presubmit-e2e-test-gce-minikube |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -0,0 +1,36 @@ | |||
| #!/bin/bash | |||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| set -x |
|
|
||
| function clean_up { | ||
| echo "Clean up..." | ||
| cd ${KFAPP} |
There was a problem hiding this comment.
This fails since $KFAPP is relative path.
* add docs on migration from Argo * Update samples/kfp-user-guide/README.md Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com> * Update README.md Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com>
The pipeline is heading towards to the Kubeflow kfctl.sh deployment. Switch the way the tests are deploying the cluster so tests are testing against actual user scenario.
This change is