Add Deletion button to archived runs #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @Bobgy |
Bobgy
reviewed
Mar 18, 2020
frontend/src/pages/Archive.test.tsx
Outdated
| @@ -60,17 +67,29 @@ describe('Archive', () => { | |||
| expect(updateBannerSpy).toHaveBeenCalledWith({}); | |||
| }); | |||
|
|
|||
| it('only enables restore button when at least one run is selected', () => { | |||
| it('only enables restore and delete button when at least one run is selected', () => { | |||
There was a problem hiding this comment.
Suggested change
| it('only enables restore and delete button when at least one run is selected', () => { | |
| it('enables restore and delete button when at least one run is selected', () => { |
frontend/src/pages/Archive.test.tsx
Outdated
| expect(deleteRunSpy).toHaveBeenCalledWith('id1'); | ||
| expect(deleteRunSpy).toHaveBeenCalledWith('id2'); | ||
| expect(deleteRunSpy).toHaveBeenCalledWith('id3'); | ||
| console.log(tree.state('selectedIds')); |
frontend/src/pages/Archive.test.tsx
Outdated
| it('deletes selected ids when Confirm is clicked', async () => { | ||
| tree = shallow(<Archive {...generateProps()} />); | ||
| tree.setState({ selectedIds: ['id1', 'id2', 'id3'] }); | ||
| console.log(tree.state('selectedIds')); |
|
FYI, your mentioned context in #3285 (comment) seems wrong. Could you double check? |
yes. changed to the bug #3283 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-sample-test |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* addd delete button to archived run page * unit test * comments * address comments * remove unintended console log in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#3283
video https://drive.google.com/file/d/1ruipA6DBIa9QERE9ur5ZGCvUj_Xctr_w/view
This change is