Clean up kataras dependency #3240
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-backend-test |
|
Thanks! |
| @@ -454,12 +454,6 @@ go_repository( | |||
| tag = "v4.2.1", | |||
| ) | |||
|
|
|||
| go_repository( | |||
There was a problem hiding this comment.
go mod tidy
then
bazel run //:gazelle -- update-repos --from_file=go.mod
?
There was a problem hiding this comment.
I did tidy but not gazelle, gazelle seems bumping versions of some dependencies automatically (in addition to just add/remove dependencies). I updated with gazelle produced diff to check if the version change will cause incompatibility issue. Otherwise, we can keep the gazelle produced diff.
|
/lgtm |
|
New changes are detected. LGTM label has been removed. |
|
/test kubeflow-pipeline-backend-test |
* cleanup kataras_iris dependency, which is only used in test * go mod tidy * bazel run //:gazelle -- update-repos --from_file=go.mod
We use kataras_iris only for its /core/errors package; and this error package is only used in our tests; and moreover, /core/errors is removed from kataras_iris in v12 and gets moved to /core/errgroup. I figured that, instead of updating the usage in our tests, we can just stop depending on it in our tests but switch to standard errors (and especially that this switch wouldn't change our production code)
Also, this dependency causes backend prow test failure when we try to migrate, due to not found the package error. Hence this pr will fix that as well.
#2885
This change is