Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Manifest] fix version for MLMD store #3237

Merged
merged 2 commits into from
Mar 9, 2020
Merged

[Manifest] fix version for MLMD store #3237

merged 2 commits into from
Mar 9, 2020

Conversation

numerology
Copy link

@numerology numerology commented Mar 7, 2020 •
edited by jlewi
Loading

It seems like they'll remove the 'v' in the version tag.

This change is Reviewable

@numerology
Copy link
Author

/assign @dushyanthsc
/assign @rmgogogo

FYI

@dushyanthsc
Copy link
Contributor

/lgtm

@kubeflow kubeflow deleted a comment from randmind Mar 9, 2020
rmgogogo
rmgogogo reviewed Mar 9, 2020
View reviewed changes
.release.cloudbuild.yaml
@@ -243,14 +243,14 @@ steps:
docker push gcr.io/ml-pipeline/google/pipelines-test/visualizationserver:$(cat /workspace/mm.ver)

- name: 'gcr.io/cloud-builders/docker'
args: ['pull', 'gcr.io/tfx-oss-public/ml_metadata_store_server:v0.21.1']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubeflow/pipelines/blob/master/.release.cloudbuild.yaml#L246

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain a bit more? A little bit of confused by the link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I means this part also need changes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you meant https://github.com/kubeflow/pipelines/blob/master/.release.cloudbuild.yaml#L263 ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed accordingly

@rmgogogo rmgogogo removed the lgtm label Mar 9, 2020
@numerology
Copy link
Author

/retest

@neuromage
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 13fc87b into kubeflow:master Mar 9, 2020
@numerology numerology deleted the fix-mlmd-version branch March 9, 2020 16:38
@numerology numerology restored the fix-mlmd-version branch March 10, 2020 16:24
@numerology numerology deleted the fix-mlmd-version branch March 10, 2020 16:24
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@Jeffwan
[Manifest] fix version for MLMD store (kubeflow#3237)
64f7daf 
* fix version

* update
@snyk-bot snyk-bot mentioned this pull request May 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmgogogo rmgogogo rmgogogo left review comments

@Bobgy Bobgy Awaiting requested review from Bobgy

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@neuromage neuromage

@rmgogogo rmgogogo

@dushyanthsc dushyanthsc

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@numerology @dushyanthsc @neuromage @k8s-ci-robot @rmgogogo