fix bug for the component build with requirements #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test presubmit-unit-test |
|
/lgtm |
|
It's a bit alarming that the feature was checked in in a broken state and tests did not catch it. I'm partially to blame for that since I did not notice this problem. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The unit tests do not run the docker command, thus missing the bug. |
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
…code (kubeflow#320) * Create a batch job to allow manual runs of auto-deploying the latest cluster. * * Add a Makefile * Pass in zone. * Move to us-east1-b becasue of kubeflow#321 * Fix zones. * Make zone required.
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
…ubeflow#320) * v1alpha2 spec for predict,explain,transform * Convert from knative configuration to service * Fix service resource tests * Fix service reconciler tests * Fix service finalizer * Fix controller test * Rename to predictor service * Fix conflicts * Watch knative service * Fix predictor route name * Fix integration test * structure reconciler for different endpoints * refactor and placeholder for explainer/transformer * shorten code :) * Use enum instead of string * use string constant for default/canary * Fix canary finalizer name * Use endpoint verb for route name
HumairAK
pushed a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is