[Tutorial] - Fixed lightweight component tutorial with bad metadata usage #3186
Conversation
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
|
/assign @Ark-kun |
|
/lgtm |
|
@animeshsingh , @saurabh24292 please help to verify as well. |
|
/lgtm |
|
@numerology Please kindly approve the PR. |
| @@ -247,7 +243,8 @@ | |||
| "metadata": {}, | |||
| "outputs": [], | |||
| "source": [ | |||
| "divmod_op = comp.func_to_container_op(my_divmod)" | |||
| "divmod_op = comp.func_to_container_op(func=my_divmod, \n", | |||
| " base_image=\"tensorflow/tensorflow:1.15.0-py3\")" | |||
There was a problem hiding this comment.
Does it really need the tensorflow image?
There was a problem hiding this comment.
Not really. As long as having base container image with python 3.5+ and Numpy installed I think. Previously, the tensorflow IO is used to dump the meta data to a file. It still serve the purpose though.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…sage (kubeflow#3186) * update the lightweight example * add instruction to avoid running authentication from AI platform notebooks
Fixes #3182
This change is