Add integration tests for version related methods #3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bobgy
approved these changes
Feb 26, 2020
| @@ -63,7 +63,8 @@ require ( | |||
| github.com/smartystreets/assertions v0.0.0-20180927180507-b2de0cb4f26d // indirect | |||
| github.com/smartystreets/goconvey v0.0.0-20181108003508-044398e4856c // indirect | |||
| github.com/spf13/viper v1.3.0 | |||
| github.com/stretchr/testify v1.2.2 | |||
| github.com/stretchr/objx v0.2.0 // indirect | |||
| github.com/stretchr/testify v1.3.0 | |||
There was a problem hiding this comment.
I wonder why you needed to upgrade testify?
There was a problem hiding this comment.
I feel this is auto changed... I didn't make this change manually.
| }) | ||
| assert.NotNil(t, err) | ||
|
|
||
| /* ---------- List pipeline version s sorted by names descend order ---------- */ |
There was a problem hiding this comment.
Suggested change
| /* ---------- List pipeline version s sorted by names descend order ---------- */ | |
| /* ---------- List pipeline versions sorted by names descend order ---------- */ |
|
/retest |
|
/lgtm |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* create a new version upload integration test file * checkpoint * checkpoint * test * checkpoint * checkpoint * version api integration test * Fix a typo * typo in comment * error message
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
…eflow#3174) Added _rest_server attribute init method. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, the integration test pipeline_version_api_test.go is going to be included in backend-api-integration-test afterwards.
Also, the work on upload version client included in this PR is related to #2977
Also related to backend integration test #3247
This change is