Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest npm and node on travis, fix tests #317

Merged
merged 2 commits into from
Nov 19, 2018
Merged

Use latest npm and node on travis, fix tests #317

merged 2 commits into from
Nov 19, 2018

Conversation

yebrahim
Copy link
Contributor

@yebrahim yebrahim commented Nov 19, 2018 •
edited by jlewi
Loading

Some snapshot tests weren't correct because of a corner case with npm vs node versions. Some tests were also not working as intended (needed to wait a little more before getting to the right state), not sure how those got the good snapshots to begin with.

This change is Reviewable

rileyjbauer
rileyjbauer approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@rileyjbauer rileyjbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@yebrahim
Copy link
Contributor Author

/approve

1 similar comment
@IronPan
Copy link
Member

IronPan commented Nov 19, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan, rileyjbauer, yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan, rileyjbauer, yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yebrahim yebrahim merged commit 003a8c8 into master Nov 19, 2018
@yebrahim yebrahim deleted the yebrahim/npm-v branch November 19, 2018 23:41
@k8s-ci-robot
Copy link
Contributor

@yebrahim: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
presubmit-unit-test 8a07216 link /test presubmit-unit-test
build-image 8a07216 link /test build-image

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@zhenghuiwang @k8s-ci-robot
Add TLS certification after creating cluster (kubeflow#317)
060df44 
* project creation

* remove project_creation

* add kuber-rsa to worker image

* add kube-rsa to image

* remove blank line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileyjbauer rileyjbauer rileyjbauer approved these changes

@qimingj qimingj Awaiting requested review from qimingj

Assignees

@rileyjbauer rileyjbauer

Labels
approved area/frontend lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yebrahim @IronPan @k8s-ci-robot @rileyjbauer