Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Always show stackdriver link in GKE #3167

Merged
merged 11 commits into from
Feb 25, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Feb 25, 2020

Resolves #2652
Resolves #2560
Resolves #1414

Demo: https://youtu.be/-RCZwpJJnyk

Changes:

  1. UI fetches and caches project id and cluster name at top level
  2. RunDetails page always show stackdriver link if project id and cluster name are available
  3. SideNav uses project id and cluster name from context instead

/area frontend
/kind feature

/assign @jingzhang36


This change is Reviewable

@jingzhang36
Copy link
Contributor

/lgtm
/approve

@jingzhang36
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingzhang36

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9998a71 into kubeflow:master Feb 25, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* [Frontend] snapshot diff setup

* Rename

* Fix test

* Update README about recommended setup

* Change SideNav to load gke metadata from context

* Fix sidenav

* RunDetails page always show stackdriver link

* Fix tests

* Fix test

* Ajust test
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Restrict workflow concurrency.

Signed-off-by: vignesh-murugani2i <vignesh.murugan@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants