Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend] snapshot diff setup #3166

Merged
merged 4 commits into from
Feb 25, 2020
Merged

[Frontend] snapshot diff setup #3166

merged 4 commits into from
Feb 25, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Feb 25, 2020 •
edited
Loading

Changes:

  1. Use inline snapshots
  2. Configure snapshot-diff to remove line number
  3. Configure snapshot-diff to remove escaped characters
  4. Common test utils for diffing HTML and shallow

Best practices:

  1. Only use inline snapshots (this makes snapshots easier to read when reading tests, also it's clear when a snapshot is too long)
  2. Avoid long snapshots, use snapshot diff or non-snapshot testing instead

This PR is aligned with https://kentcdodds.com/blog/effective-snapshot-testing/

/area frontend
/area engprod
Part of #2407
Unblocks #2652

This change is Reviewable

@Bobgy Bobgy mentioned this pull request Feb 25, 2020
Closed
16 tasks
@jingzhang36
Copy link
Contributor

/lgtm
BTW, frontend integration test seems failing

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 25, 2020
@jingzhang36
Copy link
Contributor

/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 25, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 40a887f into kubeflow:master Feb 25, 2020
@Bobgy Bobgy deleted the fe_config_snapshot_diff branch February 25, 2020 07:03
@Bobgy Bobgy mentioned this pull request Mar 22, 2020
Merged
@Bobgy Bobgy mentioned this pull request Apr 27, 2020
Merged
@Bobgy Bobgy mentioned this pull request Jun 3, 2020
Merged
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@Bobgy @Jeffwan
[Frontend] snapshot diff setup (kubeflow#3166)
cf531a0 
* [Frontend] snapshot diff setup

* Rename

* Fix test

* Update README about recommended setup
@Bobgy Bobgy mentioned this pull request Feb 13, 2021
Open
@zijianjoy zijianjoy mentioned this pull request Feb 17, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@jingzhang36 jingzhang36

Labels
approved area/engprod area/frontend lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bobgy @jingzhang36 @k8s-ci-robot