Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a missing query parameter in swagger json file for version upload api #3160

Merged
merged 4 commits into from
Feb 24, 2020

Conversation

jingzhang36
Copy link
Contributor

@jingzhang36 jingzhang36 commented Feb 24, 2020

  1. Added the pipelineid parameter in swagger json.
  2. Reran the swagger codegen for Backend
  3. TODO: will rerun codegen for Frontend as well

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jingzhang36
You can assign the PR to them by writing /assign @jingzhang36 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jingzhang36
Copy link
Contributor Author

/assign @Bobgy
/cc @IronPan

@Bobgy
Copy link
Contributor

Bobgy commented Feb 24, 2020

/lgtm

@jingzhang36 jingzhang36 merged commit 80fc767 into kubeflow:master Feb 24, 2020
@jingzhang36
Copy link
Contributor Author

/approve

Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
… api (kubeflow#3160)

* add pipelineid to api parameter

* Backend swagger autogent

* Reverse a local change

* Reverse another local change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants