Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a message in 'Get Started Page' #3152

Merged
merged 4 commits into from
Feb 24, 2020
Merged

Add a message in 'Get Started Page' #3152

merged 4 commits into from
Feb 24, 2020

Conversation

chensun
Copy link
Member

@chensun chensun commented Feb 22, 2020 •
edited by jlewi
Loading

Add a message to remind users to choose a Tensorflow 2.1 notebook instance.

/assign @IreneGi

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

@chensun: GitHub didn't allow me to assign the following users: IreneGi.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Add a message to remind users to choose a Tensorflow 2.1 notebook instance.

/assign @IreneGi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@numerology
Copy link

/assign @SinaChavoshi
/assign @Bobgy

@Bobgy
Copy link
Contributor

Bobgy commented Feb 22, 2020

Run
npm test -u
And run all tests to update snapshot tests

@chensun
Copy link
Member Author

chensun commented Feb 22, 2020

Run
npm test -u
And run all tests to update snapshot tests

Thanks! I was wondering if the snap file is manually updated or maintained by any script.

Bobgy
Bobgy approved these changes Feb 22, 2020
View reviewed changes
Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

frontend/src/pages/__snapshots__/GettingStarted.test.tsx.snap
@@ -5,7 +5,7 @@ exports[`GettingStarted page fallbacks to show pipeline list page if request fai
- First value
+ Second value

@@ -69,11 +69,13 @@
@@ -70,11 +70,13 @@
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is not a good way to do snapshot testing. I will consider alternatives.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun
Copy link
Member Author

chensun commented Feb 22, 2020

/retest

3 similar comments
@chensun
Copy link
Member Author

chensun commented Feb 22, 2020

/retest

@Bobgy
Copy link
Contributor

Bobgy commented Feb 22, 2020

/retest

@chensun
Copy link
Member Author

chensun commented Feb 22, 2020

/retest

@Bobgy
Copy link
Contributor

Bobgy commented Feb 22, 2020 •
edited
Loading

The failure here in xgboost is the same as https://travis-ci.com/kubeflow/pipelines/jobs/290012541.

python2 cannot find enum module, I'm suspecting some modules are no longer supporting python2 because it is no longer maintained. Maybe we can workaround by https://stackoverflow.com/a/40655587, but I think we should upgrade all components to use python3 instead.
e.g. new google cloud python libraries don't support python2 any more: https://cloud.google.com/python/docs/python2-sunset

@numerology numerology mentioned this pull request Feb 22, 2020
Closed
@numerology
Copy link

FYI I filed #3155

@Bobgy
Copy link
Contributor

Bobgy commented Feb 24, 2020

/retest

@Bobgy
Copy link
Contributor

Bobgy commented Feb 24, 2020

/retest
/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 58bdca7 into kubeflow:master Feb 24, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@chensun @Jeffwan
Add a message in 'Get Started Page' (kubeflow#3152)
cae39dd 
* Add a message in 'Get Started Page'

* remove extra empty line

* attempt to fix test

* update snapshot
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@sivanantha321
Generate client-go for StorageContainer CR (kubeflow#3152)
fe3411f 
* Generate client-go

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Generate manifests

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobgy Bobgy Bobgy approved these changes

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@Bobgy Bobgy

@SinaChavoshi SinaChavoshi

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chensun @k8s-ci-robot @numerology @Bobgy @SinaChavoshi