Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend] Pin links in getting started page when release #3147

Merged
merged 3 commits into from
Feb 22, 2020
Merged

[Frontend] Pin links in getting started page when release #3147

merged 3 commits into from
Feb 22, 2020

Conversation

numerology
Copy link

@numerology numerology commented Feb 21, 2020 •
edited by jlewi
Loading

This change is Reviewable

@numerology
Copy link
Author

/assign @Bobgy
/assign @SinaChavoshi

The idea is similar to what we're doing for backend: in source code point to the master, and pin the link to the permalink each time we release the image.

@Bobgy
Copy link
Contributor

Bobgy commented Feb 21, 2020

Thanks @numerology
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 91db95a into kubeflow:master Feb 22, 2020
@numerology numerology deleted the frontend-release-doc-pin branch February 27, 2020 16:40
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@Jeffwan
[Frontend] Pin links in getting started page when release (kubeflow#3147
2d91e58 
)

* release TFX from bypassing

* lint

* fix?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobgy Bobgy Awaiting requested review from Bobgy

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@Bobgy Bobgy

@SinaChavoshi SinaChavoshi

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@numerology @Bobgy @k8s-ci-robot @SinaChavoshi