Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Update contribution doc with start proxy instructions and npm daily practices #3142

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Feb 21, 2020

/area frontend
/area docs

Resolves #2461
Resolves #2452


This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 21, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy Bobgy added the lgtm label Feb 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 492d067 into kubeflow:master Feb 21, 2020
@Bobgy Bobgy deleted the fe_npm_handbook branch February 21, 2020 11:43
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants