Add default_gcp_op #314
Add default_gcp_op #314
Conversation
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from .kubeflow_tfjob_launcher_op import kubeflow_tfjob_launcher_op |
|
|
||
| from kfp import dsl | ||
| from typing import Dict | ||
| from kubernetes import client as k8s_client |
There was a problem hiding this comment.
Can you please move the kubernetes import inside the function?
Although we state that we require the kubernetes package, it's nice to be able to use most of our library without it.
| service account access permission. | ||
| """ | ||
| return dsl.ContainerOp(name, image, command, arguments, file_inputs, | ||
| file_outputs, is_exit_handler). \ |
There was a problem hiding this comment.
Can you please move the dot to the next line?
You can use parentheses to allow line breaking without slashes: https://stackoverflow.com/questions/4768941/how-to-break-a-line-of-chained-methods-in-python
There was a problem hiding this comment.
and thanks for the suggestion of parentheses. I think slash is not uncommon to see so maybe just use it for now? we can switch when we see it pain to read
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-Authored-By: IronPan <yangpa@google.com>
|
/lgtm |
* improve dev manfests and docs * Address comments
This operator mount the default service account secret to the container. The default service account is created by kubeflow deployment.
This change is