Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] swf catchup option integration tests #3139

Merged
merged 15 commits into from
Feb 21, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Feb 21, 2020

The last PR for #3055.
Resolves #3055.

/area backend
/area testing


This change is Reviewable

@jingzhang36
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 21, 2020
@jingzhang36
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingzhang36

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 21, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8c0bc21 into kubeflow:master Feb 21, 2020
@Bobgy Bobgy deleted the test_swf_catchup_integration branch February 21, 2020 11:45
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* Make local testing easier

* Move cleanup to test setup stage

* Add readme for how to run integration tests

* Add warning about data loss

* Add warning also in the script

* Change flag to isDevMode and cleanup resources if not in dev mode

* Pass through arguments in the bash script

* Fix unit tests

* integration tests for swf NoCatchup option

* Also add cron catchup option tests

* Restructure test

* Adjust format

* Fix BUILD.bazel

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduled workflow catchup=false behavior like airflow
3 participants