Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifests: Rename metadata gRPC server's resources to metadata-grpc-* #3108

Merged
merged 3 commits into from
Mar 27, 2020

Commits on Mar 11, 2020

  1. Manifests: Rename metadata gRPC server's resources to metadata-grpc-*

    The metadata service deployed is a gRPC server.
    
    Proper KF installation deploys both an HTTP server, naming the required
    resources as 'metadata-deployment' and 'metadata-service', as well as a
    gRPC server, naming the corresponding resources
    'metadata-grpc-deployment' and 'metadata-grpc-service'.
    
    KFP standalone installation manifests deploy solely the gRPC server, but
    use naming identical to the KF's HTTP server one.
    Applying them on top of an existing KF cluster breaks Metadata service.
    
    In this PR we change the naming making it not diverge from a proper KF
    installation. We also make MetadataWriter aware of that change.
    
    Closes kubeflow#2889.
    
    Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
    elikatsis committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    c2b0dc4 View commit details
    Browse the repository at this point in the history
  2. Fix ConfigMaps' label

    * metadata-configmap
    * metadata-mysql-configmap
    elikatsis committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    3d4e2c7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc304ca View commit details
    Browse the repository at this point in the history