Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ml_engine component READMEs incorrect #3103

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

TheMichaelHu
Copy link
Contributor

@TheMichaelHu TheMichaelHu commented Feb 18, 2020

The output sections of the deploy and batch_prediction component's READMEs are
incorrect. Updated to reflect the actual outputs.


This change is Reviewable

The output sections of the deploy and batch_prediction component's READMEs are
incorrect. Updated to reflect the actual outputs.
@k8s-ci-robot
Copy link
Contributor

Hi @TheMichaelHu. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TheMichaelHu
Copy link
Contributor Author

/assign @numerology

@numerology
Copy link

/ok-to-test

@numerology
Copy link

Thanks @TheMichaelHu !

@numerology
Copy link

/retest
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TheMichaelHu
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7c4dd71 into kubeflow:master Feb 19, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
The output sections of the deploy and batch_prediction component's READMEs are
incorrect. Updated to reflect the actual outputs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants