Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XGBoost demo - change quota calculation #3093

Merged
merged 3 commits into from
Feb 18, 2020

Conversation

SinaChavoshi
Copy link
Contributor

@SinaChavoshi SinaChavoshi commented Feb 15, 2020

This change is Reviewable

@SinaChavoshi SinaChavoshi changed the title XGBoost demo - change quota calculation [wip]XGBoost demo - change quota calculation Feb 15, 2020
@SinaChavoshi SinaChavoshi reopened this Feb 15, 2020
@SinaChavoshi SinaChavoshi changed the title [wip]XGBoost demo - change quota calculation XGBoost demo - change quota calculation Feb 15, 2020
@Ark-kun
Copy link
Contributor

Ark-kun commented Feb 15, 2020

/lgtm

@SinaChavoshi
Copy link
Contributor Author

/retest

@SinaChavoshi SinaChavoshi deleted the xgboost_demo branch February 18, 2020 16:46
@SinaChavoshi SinaChavoshi restored the xgboost_demo branch February 18, 2020 17:05
@SinaChavoshi SinaChavoshi reopened this Feb 18, 2020
@SinaChavoshi
Copy link
Contributor Author

Closed by mistake reopening

@numerology
Copy link

/approve

@numerology
Copy link

@SinaChavoshi you might need to change the sample test config again... since worker is removed from the pipeline signature.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SinaChavoshi
Copy link
Contributor Author

/retest

@numerology
Copy link

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 9f41e68 into kubeflow:master Feb 18, 2020
@SinaChavoshi SinaChavoshi deleted the xgboost_demo branch February 21, 2020 19:30
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* removing worker count , and changing quota

* removing worker count from sample test

* removing comma after worker int value
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Unpack archive files for hdfs

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Resolve comments

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Co-authored-by: nayak <smita.naik@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants