-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix metadata_writer service connection to a proper GRPC server #3087
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @areshytko. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This change shouldn't be made on its own. Please refer to #2889 for context. I've prepared a PR that targets the issue, but I didn't have the time to test it thoroughly. I should have it ready early next week. |
It would be great if the PR is minimal. Is it significantly bigger than changing the service names in the manifests and in Metadata Writer? We'd like to see the PR soon. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
this is now integrated with kubeflow |
Metadata service uses ml_metadata python API but tries to connect to kubeflow metadata service instead of TFX metadata service hence it fails to connect with the error:
Expected behavior:
Should connect to metadata server without any errors
Actual behavior before this PR:
Pod fails with the following error in logs:
How to test
metadata_writer:latest
This change is