Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Visualization only loads on completed nodes #3082

Merged
merged 2 commits into from
Feb 14, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Feb 14, 2020

Fixes #3080

Changes: this fixes the bug by only refetching data when selected node phase changes to completed.

/area frontend
/kind bug


This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 14, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy Bobgy added the lgtm label Feb 14, 2020
@Bobgy Bobgy self-assigned this Feb 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit b444f56 into kubeflow:master Feb 14, 2020
@Bobgy Bobgy deleted the fe_fix_vis_always_loading branch February 16, 2020 05:44
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* Visualization only loads on succeeded nodees

* Also allow failed nodes to visualize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Artifact visualization always loading when still running
2 participants