Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples - Add explanation about pipeline failing intentionally #3076

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Feb 14, 2020

This change is Reviewable

@numerology
Copy link

/lgtm
/approve

@joeliedtke
Copy link
Member

Thank you for adding this PR! This should help make the behavior of the pipeline clear for new users.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 14, 2020
@joeliedtke
Copy link
Member

/lgtm

@IronPan
Copy link
Member

IronPan commented Feb 14, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan, numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numerology
Copy link

/retest

1 similar comment
@numerology
Copy link

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8ff9305 into kubeflow:master Feb 14, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
…low#3076)

* Samples - Add explanation about pipeline failing intentionally

* Fixed grammar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants