-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Pipeline/Workspace field in ArtifactList table #3063
Fix Pipeline/Workspace field in ArtifactList table #3063
Conversation
/hold cancel |
Updated deployment to the latest image: https://6d1629804d56a867-dot-us-central2.pipelines.googleusercontent.com/#/artifacts |
/lgtm |
/assign @rmgogogo for approval |
@kwasi: GitHub didn't allow me to assign the following users: for, approval. Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @Bobgy |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest
Thanks! LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avdaredevil, Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@kwasi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* Check for pipeline name in ArtifactCustomProperties * Move array creation out of map in getRowsFromArtifacts() * Bump to latest kubeflow/frontend hash to pick up exported function * Fix package.json * Run prettier
Resolves kubeflow#3063 Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
/assign @kwasi
/cc @avdaredevil
/priority p0
/area front-end
/hold
Hold until kubeflow/frontend#41 is merged.
Fixes kubeflow/frontend#38
Verification
Deployed against the 0.2.2 marketplace deploy here: https://6d1629804d56a867-dot-us-central2.pipelines.googleusercontent.com/#/artifacts
This change is