Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pipeline/Workspace field in ArtifactList table #3063

Merged
merged 5 commits into from
Feb 13, 2020

Conversation

kwasi
Copy link
Contributor

@kwasi kwasi commented Feb 12, 2020

/assign @kwasi
/cc @avdaredevil
/priority p0
/area front-end
/hold

Hold until kubeflow/frontend#41 is merged.

Fixes kubeflow/frontend#38

Verification

Deployed against the 0.2.2 marketplace deploy here: https://6d1629804d56a867-dot-us-central2.pipelines.googleusercontent.com/#/artifacts


This change is Reviewable

@kwasi
Copy link
Contributor Author

kwasi commented Feb 12, 2020

/hold cancel

@kwasi
Copy link
Contributor Author

kwasi commented Feb 12, 2020

Updated deployment to the latest image: https://6d1629804d56a867-dot-us-central2.pipelines.googleusercontent.com/#/artifacts

@avdaredevil
Copy link
Contributor

/lgtm
/approve

@kwasi
Copy link
Contributor Author

kwasi commented Feb 13, 2020

/assign @rmgogogo for approval

@k8s-ci-robot
Copy link
Contributor

@kwasi: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @rmgogogo for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwasi
Copy link
Contributor Author

kwasi commented Feb 13, 2020

/cc @Bobgy

@rmgogogo
Copy link
Contributor

/retest

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

Thanks! LGTM

frontend/src/pages/ArtifactList.tsx Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avdaredevil, Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor

Bobgy commented Feb 13, 2020

/retest

@Bobgy Bobgy merged commit 18a26de into kubeflow:master Feb 13, 2020
@k8s-ci-robot
Copy link
Contributor

@kwasi: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pipeline-sample-test 36f1e45 link /test kubeflow-pipeline-sample-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* Check for pipeline name in ArtifactCustomProperties

* Move array creation out of map in getRowsFromArtifacts()

* Bump to latest kubeflow/frontend hash to pick up exported function

* Fix package.json

* Run prettier
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Resolves kubeflow#3063

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MLMD] No name is displayed in the Lineage Explorer for the TFX Taxi example
5 participants