Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update TFDV to 0.21.1 which can work for Chrome 80 #3060

Merged
merged 4 commits into from
Feb 13, 2020
Merged

update TFDV to 0.21.1 which can work for Chrome 80 #3060

merged 4 commits into from
Feb 13, 2020

Conversation

rmgogogo
Copy link
Contributor

@rmgogogo rmgogogo commented Feb 12, 2020

This change is Reviewable

@rmgogogo
Copy link
Contributor Author

/retest

1 similar comment
@rmgogogo
Copy link
Contributor Author

/retest

@jingzhang36
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingzhang36

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rmgogogo
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 13, 2020
@rmgogogo rmgogogo changed the title update TFDV to 0.21.1 which can work for Chrome update TFDV to 0.21.1 which can work for Chrome 80 Feb 13, 2020
@rmgogogo rmgogogo added the lgtm label Feb 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0623ac1 into kubeflow:master Feb 13, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* done

* some dependency issue

* wait for PR3067

Co-authored-by: renmingu <40223865+renmingu@users.noreply.github.com>
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Storage container CRD

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Add CRD to helm

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Add default CR

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Fix default storage container cr

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Update kserve-manager-role in helm charts

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Update crd format, modify controller code and tests

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Update helm charts

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* fix cluster role

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Remove name from CRD

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Update CRD in helm

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Error handling

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Fix kubebuilder rbac annotation

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Add comments

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Fix test

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Update comments

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

---------

Signed-off-by: Jin Dong <jdong183@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants