Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable namespaces in sample test and python SDK #306

Merged
merged 3 commits into from
Nov 17, 2018

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Nov 16, 2018

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 17, 2018

/lgtm

@gaoning777
Copy link
Contributor Author

/test presubmit-e2e-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 17, 2018

/lgtm

@IronPan
Copy link
Member

IronPan commented Nov 17, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member

IronPan commented Nov 17, 2018

thanks for the fix

@k8s-ci-robot k8s-ci-robot merged commit b394357 into master Nov 17, 2018
@gaoning777 gaoning777 deleted the ngao/configurable-sample-test-ns branch November 19, 2018 17:48
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* Setup a new GKE cluster running the label_sync_cron job.
* Run this on a separate admin cluster because it requires write
  privileges on REPOs.

* Create DM configs for setting up this cluster.

Fix kubeflow#299
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* See if this fixes the test failures updating the jupyter web app
  image kubeflow/kubeflow#3254

related to kubeflow#306
related to kubeflow/kubeflow#3254
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* It looks like ApiException doesn't always store the HttpStatus code in .status
   in some cases it will be stored in the body
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants