-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix config fieldname PipelineFolder
to PipelinePath
#3056
Fix config fieldname PipelineFolder
to PipelinePath
#3056
Conversation
Hi @eterna2. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm Looks like an open ssl issue inside build container.
|
/retest |
1 similar comment
/retest |
/ok-to-test |
@jingzhang36 @IronPan for review |
@Ark-kun @jingzhang36 @IronPan kindly ping. :D |
@Bobgy @neuromage Could you help approve this PR? This is a follow up PR of #2080 : |
/approve There are no existing usages, it's safe to rename. |
/assign @IronPan |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test kubeflow-pipeline-frontend-test |
With reference to PR #2080 :
param to customize the pipeline path to save the pipeline templates (
PipelineFolder
) was supposed to be renamed toPipelinePath
. However, theconfig.json
as well as the config field was not renamed.This PR fix this oversight - i.e. rename the config field to
PipelinePath
, and updates theconfig.json
.cc: @Jeffwan
This change is