[Test] Add docker daemon start in test base image #3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds Dockerfile for our e2e test by extending kubekins image.
Co-Authored-By: Jiaxiao Zheng <jxzheng@google.com>
|
/assign @numerology |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: numerology The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* Add Dockerfile for KFP e2e test This commit adds Dockerfile for our e2e test by extending kubekins image. * Add e2e test base image * Add README.md * Fix README.md code block inline issue * Fix README.md code align issue * Fix README.md code align issue * Fix link and docker build tag version * Update test/images/README.md Co-Authored-By: Jiaxiao Zheng <jxzheng@google.com> * Fix image tag * Fix build failure * Fix build failure * Add docker daemon start config on test base image Co-authored-by: Jiaxiao Zheng <jxzheng@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds docker daemon start in test base image. Currently our post submits complain about https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/kubeflow-pipeline-postsubmit-mkp-component-test/1227400772560359428#1:build-log.txt%3A922 after sudo installed.
Reference: https://forums.docker.com/t/cannot-connect-to-the-docker-daemon-is-the-docker-daemon-running-on-this-host/8925/3
Part of #2950
This change is