Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding auth list support for diagnose_me #3052

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

SinaChavoshi
Copy link
Contributor

@SinaChavoshi SinaChavoshi commented Feb 11, 2020

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Feb 11, 2020

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Feb 11, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8879960 into kubeflow:master Feb 11, 2020
@SinaChavoshi SinaChavoshi deleted the diagnose_me_auth branch February 14, 2020 15:55
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* Adding auth list support for diagnose_me

* correcting formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants