Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XGBoost demo - Removing unnecessary parameters and adding quota check. #3049

Merged
merged 9 commits into from
Feb 14, 2020

Conversation

SinaChavoshi
Copy link
Contributor

@SinaChavoshi SinaChavoshi commented Feb 11, 2020

Goal of this PR is to limit the parameters for the XGboost demo pipeline.


This change is Reviewable

@SinaChavoshi SinaChavoshi changed the title Removing unnecessary parameters. XGBoost demo - Removing unnecessary parameters. Feb 11, 2020
@numerology
Copy link

Do you mind adding one line to xgboost_training_cm/README.md to let users know how to play with their own data and schema? Thanks!

@numerology
Copy link

@SinaChavoshi

You might need to change /test/sample-test/configs/xgboost_training_cm.config.yaml as well. Currently sample test launcher will attempt to override the workflow parameters using the arguments section in the config yaml. However after this PR there won't be things like train_data, so it'll error out.

@rmgogogo
Copy link
Contributor

/retest

1 similar comment
@rmgogogo
Copy link
Contributor

/retest

@SinaChavoshi
Copy link
Contributor Author

@numerology thank you for calling this out, updated the test config yaml as well as read me file. kindly let me know if there is any feedback.

@SinaChavoshi SinaChavoshi changed the title XGBoost demo - Removing unnecessary parameters. [WIP] XGBoost demo - Removing unnecessary parameters. Feb 13, 2020
@SinaChavoshi
Copy link
Contributor Author

changed to WIP to incorporate quota verification changes from @numerology update to diagnose_me component.

@SinaChavoshi SinaChavoshi changed the title [WIP] XGBoost demo - Removing unnecessary parameters. XGBoost demo - Removing unnecessary parameters. Feb 14, 2020
@numerology numerology changed the title XGBoost demo - Removing unnecessary parameters. XGBoost demo - Removing unnecessary parameters and adding quota check. Feb 14, 2020
Co-Authored-By: Jiaxiao Zheng <jxzheng@google.com>
@numerology
Copy link

/lgtm
/approve
Thanks @SinaChavoshi !

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0f5a8de into kubeflow:master Feb 14, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
kubeflow#3049)

* Removing unnecessary parameters.

* changing default workers to 1 and rounds to 5

* removing region

* Adding quota check

* correcting typo

* updating the diagnose_me component

* Removing fail on error for diagnostic step

* Update samples/core/xgboost_training_cm/xgboost_training_cm.py

Co-Authored-By: Jiaxiao Zheng <jxzheng@google.com>

Co-authored-by: Jiaxiao Zheng <jxzheng@google.com>
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
…d` (kubeflow#3049)

* Create a separate action to free-up disk space on GH action runner
* Move 'free-up-disk-space' step outside 'minikube-setup' action
* Free-up disk space before running 'predictor-runtime-build'

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants