[Backend] Improve parameter patching #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
added 2 commits
February 7, 2020 14:23
|
/assign @IronPan |
|
/hold |
|
/hold cancel |
numerology
changed the title
neuromage
reviewed
Feb 8, 2020
|
/lgtm |
added 2 commits
February 7, 2020 16:12
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest |
|
/retest |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* update * move patching logic * update placeholders * move to api converter * refactor some tests * fix main.go * default remote build to false * patch everything * remove api converter patching * clean up * fix constant
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it patches for all pipelines including preload and custom ones and tmp ones (e.g. ones created from
create_run_from_pipeline_func. Also change XGboost and TFX sample to comply to new convention.We now commit to the following conventional placeholders:
{{kfp-default-bucket}}for default bucket deployed with KFP; and{{kfp-project-id}}for current GCP project ID.Verified at: https://3ed47013582d1554-dot-us-central2.pipelines.googleusercontent.com/#/runs/details/876b4f92-b1dc-4b3a-9332-1e3a5d6ae1c8
Small side change: default remote build to false, otherwise we are always using remote building.
This change is